Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy Grave Escape keycodes #18787

Merged
merged 13 commits into from
Oct 21, 2022
Merged

Remove legacy Grave Escape keycodes #18787

merged 13 commits into from
Oct 21, 2022

Conversation

fauxpark
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 20, 2022
@fauxpark fauxpark requested a review from a team October 20, 2022 13:23
@fauxpark fauxpark changed the title KC_GESC -> QK_GESC, 0-9 Remove legacy Grave Escape keycodes Oct 20, 2022
tzarc
tzarc approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of non-EN docs changes left.

@drashna drashna merged commit 1cb1a5a into qmk:develop Oct 21, 2022
@fauxpark fauxpark deleted the remove-legacy-grave-esc-keycodes branch October 21, 2022 01:04
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Remove legacy Grave Escape keycodes (qmk#18787)
70845fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @tzarc @zvecr