Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy sendstring keycodes #18749

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Remove legacy sendstring keycodes #18749

merged 1 commit into from
Oct 17, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 16, 2022 •
edited
Loading

Description

These were never properly "deprecated", but given they're meant to be in line with the KC_ keycodes, it was kind of implied.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 16, 2022 22:26
@github-actions github-actions bot removed the keyboard label Oct 16, 2022
@zvecr zvecr merged commit bad8c59 into qmk:develop Oct 17, 2022
@fauxpark fauxpark deleted the remove-legacy-send-string-keycodes branch October 17, 2022 12:53
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Remove legacy sendstring keycodes (qmk#18749)
69f4aaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr