Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Add new IIDX gamepad keymap for Synth Labs Solo #18741

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

hongaaronc
Copy link
Contributor

@hongaaronc hongaaronc commented Oct 16, 2022

Description

These changes add another keymap, which makes this macropad function as a gamepad which works out-of-the-box with the game beatmania IIDX INFINITAS.

I have tested this keymap manually in-game, and verified that the behavior works as expected. Please also refer to the new README to see what the expected behaviors are.

The rotary encoder in this keymap is intended to have slightly different behavior from the most standard rotary encoder implementation:

  • In the most rotary encoder implementations, spinning an encoder continuously generally outputs repeated taps of a keycode
  • In this implementation, spinning an encoder continuously outputs a keycode being pressed and held until the spinning stops
  • Additionally, if a spinning encoder's direction changes, release the keycode corresponding to the previous direction immediately

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@hongaaronc hongaaronc changed the title [Keymap] Add new keymap to allow plug-and-play support for IIDX game [Keymap] Add new IIDX gamepad keymap for Synth Labs Solo Oct 16, 2022
@drashna drashna requested a review from a team October 21, 2022 05:06
@drashna drashna requested a review from a team October 25, 2022 05:33
@hongaaronc
Copy link
Contributor Author

hongaaronc commented Oct 25, 2022

Thanks for looking over the changes and for the approvals. Looks like I don’t have authorization to merge though, so could someone help merge them for me? I don’t have anything further that I intend to change on this PR, so should be good to go from my side.

@drashna drashna merged commit 99d5b55 into qmk:master Oct 26, 2022
@hongaaronc
Copy link
Contributor Author

Thanks!

hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants