Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RGBLIGHT_ANIMATION and clean up effect defines for layouts+users #18729

Merged
merged 1 commit into from
Oct 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion layouts/community/60_iso/unxmaal/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#ifndef RGB_DI_PIN
#define RGB_DI_PIN F4
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 8 // Number of LEDs
#define RGBLIGHT_HUE_STEP 8
#define RGBLIGHT_SAT_STEP 8
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/ergodox/jackhumbert/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,16 @@

/* ws2812 RGB LED */
#define RGB_DI_PIN D7
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 15 // Number of LEDs
#define RGBLIGHT_HUE_STEP 12
#define RGBLIGHT_SAT_STEP 255
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/numpad_5x6/bjohnson/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@
#if defined(RGBLIGHT_ENABLE) && !defined(RGBLED_NUM)
#define RGB_DI_PIN B7
#define RGBLED_NUM 13 // Number of LEDs
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE

#define RGBLIGHT_HUE_STEP 12
#define RGBLIGHT_SAT_STEP 12
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/ortho_4x12/bakingpy/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,16 @@
#define TAPPING_TERM 150

#undef RGBLED_NUM
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 12
#define RGBLED_SPLIT { 6, 6 }
#define RGBLIGHT_HUE_STEP 8
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/ortho_4x12/xyverz/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
#define RGBLED_NUM 1
#endif

#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLIGHT_HUE_STEP 8
#define RGBLIGHT_SAT_STEP 8
#define RGBLIGHT_VAL_STEP 8
Expand Down
13 changes: 11 additions & 2 deletions layouts/community/ortho_5x12/drashna/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,17 @@
#if defined(KEYBOARD_fractal)
# define RGB_DI_PIN D2
# undef RGBLED_NUM
# define RGBLIGHT_ANIMATIONS
# define RGBLED_NUM 29 // Number of LEDs
# define RGBLIGHT_EFFECT_BREATHING
# define RGBLIGHT_EFFECT_RAINBOW_MOOD
# define RGBLIGHT_EFFECT_RAINBOW_SWIRL
# define RGBLIGHT_EFFECT_SNAKE
# define RGBLIGHT_EFFECT_KNIGHT
# define RGBLIGHT_EFFECT_CHRISTMAS
# define RGBLIGHT_EFFECT_STATIC_GRADIENT
# define RGBLIGHT_EFFECT_RGB_TEST
# define RGBLIGHT_EFFECT_ALTERNATING
# define RGBLIGHT_EFFECT_TWINKLE
# define RGBLED_NUM 29 // Number of LEDs
# undef RGBLIGHT_HUE_STEP
# define RGBLIGHT_HUE_STEP 8
# undef RGBLIGHT_SAT_STEP
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/ortho_5x12/xyverz/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,16 @@
#if defined(KEYBOARD_preonic_rev2)
#define RGB_DI_PIN B3
#undef RGBLED_NUM
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 11 // Number of LEDs
#undef RGBLIGHT_HUE_STEP
#define RGBLIGHT_HUE_STEP 8
Expand Down
13 changes: 11 additions & 2 deletions layouts/community/ortho_5x14/yet-another-developer/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,17 @@
#if defined(KEYBOARD_fractal)
# define RGB_DI_PIN D2
# undef RGBLED_NUM
# define RGBLIGHT_ANIMATIONS
# define RGBLED_NUM 29 // Number of LEDs
# define RGBLIGHT_EFFECT_BREATHING
# define RGBLIGHT_EFFECT_RAINBOW_MOOD
# define RGBLIGHT_EFFECT_RAINBOW_SWIRL
# define RGBLIGHT_EFFECT_SNAKE
# define RGBLIGHT_EFFECT_KNIGHT
# define RGBLIGHT_EFFECT_CHRISTMAS
# define RGBLIGHT_EFFECT_STATIC_GRADIENT
# define RGBLIGHT_EFFECT_RGB_TEST
# define RGBLIGHT_EFFECT_ALTERNATING
# define RGBLIGHT_EFFECT_TWINKLE
# define RGBLED_NUM 29 // Number of LEDs
# undef RGBLIGHT_HUE_STEP
# define RGBLIGHT_HUE_STEP 8
# undef RGBLIGHT_SAT_STEP
Expand Down
11 changes: 10 additions & 1 deletion layouts/community/tkl_ansi/brandonschlack/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,14 @@
#pragma once

// Explicit RGB Animation Mode Include
#undef RGBLIGHT_ANIMATIONS
#undef RGBLIGHT_EFFECT_RAINBOW_MOOD
#undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
#undef RGBLIGHT_EFFECT_SNAKE
#undef RGBLIGHT_EFFECT_KNIGHT
#undef RGBLIGHT_EFFECT_CHRISTMAS
#undef RGBLIGHT_EFFECT_STATIC_GRADIENT
#undef RGBLIGHT_EFFECT_RGB_TEST
#undef RGBLIGHT_EFFECT_ALTERNATING
#undef RGBLIGHT_EFFECT_TWINKLE

#define RGBLIGHT_EFFECT_BREATHING // Only have Breathing Animation
8 changes: 7 additions & 1 deletion users/curry/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
#define USB_POLLING_INTERVAL_MS 1

#if defined(RGBLIGHT_ENABLE)
# undef RGBLIGHT_ANIMATIONS
# undef RGBLIGHT_EFFECT_RAINBOW_MOOD
# undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
# undef RGBLIGHT_EFFECT_CHRISTMAS
# undef RGBLIGHT_EFFECT_STATIC_GRADIENT
# undef RGBLIGHT_EFFECT_RGB_TEST
# undef RGBLIGHT_EFFECT_ALTERNATING
# undef RGBLIGHT_EFFECT_TWINKLE
# define RGBLIGHT_SLEEP
# define RGBLIGHT_EFFECT_BREATHING
# define RGBLIGHT_EFFECT_SNAKE
Expand Down
11 changes: 10 additions & 1 deletion users/drashna/post_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,16 @@

// because layouts seem to not be respecting config.h order atm
#ifdef RGBLIGHT_ENABLE
# undef RGBLIGHT_ANIMATIONS
# undef RGBLIGHT_EFFECT_BREATHING
# undef RGBLIGHT_EFFECT_RAINBOW_MOOD
# undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
# undef RGBLIGHT_EFFECT_SNAKE
# undef RGBLIGHT_EFFECT_KNIGHT
# undef RGBLIGHT_EFFECT_CHRISTMAS
# undef RGBLIGHT_EFFECT_STATIC_GRADIENT
# undef RGBLIGHT_EFFECT_RGB_TEST
# undef RGBLIGHT_EFFECT_ALTERNATING
# undef RGBLIGHT_EFFECT_TWINKLE
# if defined(__AVR__) && (!defined(__AVR_AT90USB1286__) && !defined(RGBLIGHT_ALL_ANIMATIONS))
# define RGBLIGHT_EFFECT_BREATHING
# define RGBLIGHT_EFFECT_SNAKE
Expand Down
11 changes: 10 additions & 1 deletion users/greatwizard/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,16 @@

#define TAP_CODE_DELAY 5

#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE

#ifdef TAP_DANCE_ENABLE
# define TAPPING_TERM 175
Expand Down
1 change: 0 additions & 1 deletion users/ishtob/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

/* ws2812 RGB LED
#define RGB_DI_PIN B5
#define RGBLIGHT_ANIMATIONS
#define RGBLED_NUM 8 // Number of LEDs
#define RGBLIGHT_HUE_STEP 10
#define RGBLIGHT_SAT_STEP 17
Expand Down
1 change: 0 additions & 1 deletion users/kageurufu/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ EXTRAKEY_ENABLE = yes
COMMAND_ENABLE = yes
CONSOLE_ENABLE = yes
RGBLIGHT_ENABLE = no
RGBLIGHT_ANIMATIONS = yes
11 changes: 10 additions & 1 deletion users/konstantin/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,16 @@
#define MOUSEKEY_WHEEL_TIME_TO_MAX 50

// RGB lighting
#undef RGBLIGHT_ANIMATIONS
#undef RGBLIGHT_EFFECT_BREATHING
spidey3 marked this conversation as resolved.
Show resolved Hide resolved
#undef RGBLIGHT_EFFECT_RAINBOW_MOOD
#undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
#undef RGBLIGHT_EFFECT_SNAKE
#undef RGBLIGHT_EFFECT_KNIGHT
#undef RGBLIGHT_EFFECT_CHRISTMAS
#undef RGBLIGHT_EFFECT_STATIC_GRADIENT
#undef RGBLIGHT_EFFECT_RGB_TEST
#undef RGBLIGHT_EFFECT_ALTERNATING
#undef RGBLIGHT_EFFECT_TWINKLE
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
20 changes: 14 additions & 6 deletions users/kuchosauronad0/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,17 @@
#endif // !AUDIO_ENABLE

#ifdef RGBLIGHT_ENABLE
# define RGBLIGHT_SLEEP
# undef RGBLIGHT_ANIMATIONS
# undef RGBLIGHT_SLEEP
#undef RGBLIGHT_EFFECT_BREATHING
#undef RGBLIGHT_EFFECT_RAINBOW_MOOD
#undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
#undef RGBLIGHT_EFFECT_SNAKE
#undef RGBLIGHT_EFFECT_KNIGHT
#undef RGBLIGHT_EFFECT_CHRISTMAS
#undef RGBLIGHT_EFFECT_STATIC_GRADIENT
#undef RGBLIGHT_EFFECT_RGB_TEST
#undef RGBLIGHT_EFFECT_ALTERNATING
#undef RGBLIGHT_EFFECT_TWINKLE
# define RGBLIGHT_HUE_STEP 16
# define RGBLIGHT_SAT_STEP 16
# define RGBLIGHT_VAL_STEP 16
Expand All @@ -44,12 +53,12 @@
#if defined(LEADER_ENABLE)
# define LEADER_PER_KEY_TIMING
# define LEADER_TIMEOUT 250
#endif // !LEADER_ENABLE
#endif // !LEADER_ENABLE

#if defined(COMBO_ENABLE)
# define COMBO_COUNT 4
# define COMBO_TERM 150
#endif // !COMBO_ENABLE
#endif // !COMBO_ENABLE

#if defined(NKRO_ENABLE)
# define FORCE_NKRO
Expand Down Expand Up @@ -82,5 +91,4 @@

#define TAP_CODE_DELAY 5

#define MACRO_TIMER 5

#define MACRO_TIMER 5
11 changes: 10 additions & 1 deletion users/mechmerlin/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,16 @@

#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SLEEP
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#endif // RGBLIGHT_ENABLE

#ifdef RGB_MATRIX_ENABLE
Expand Down
17 changes: 13 additions & 4 deletions users/miles2go/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,16 @@

#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SLEEP
#undef RGBLIGHT_ANIMATIONS
#undef RGBLIGHT_EFFECT_RAINBOW_MOOD
#undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
#undef RGBLIGHT_EFFECT_SNAKE
#undef RGBLIGHT_EFFECT_KNIGHT
#undef RGBLIGHT_EFFECT_CHRISTMAS
#undef RGBLIGHT_EFFECT_STATIC_GRADIENT
#undef RGBLIGHT_EFFECT_RGB_TEST
#undef RGBLIGHT_EFFECT_ALTERNATING
#undef RGBLIGHT_EFFECT_TWINKLE

#define RGBLIGHT_EFFECT_BREATHING
#endif // RGBLIGHT_ENABLE

Expand Down Expand Up @@ -33,11 +42,11 @@
#define BABL_MODSWAP
#define BABL_MOVE // Uncomment to add basic cursor movement
#define BABL_OSKEYS // This adds Cut, paste, window movement and common OS shortcuts
#define BABL_BROWSER // Browser shortcuts, with Chrome/Firefox as the default.
// edit the appropriate OS config file to enable Safari, Edge, vimpirator &etc.
#define BABL_BROWSER // Browser shortcuts, with Chrome/Firefox as the default.
// edit the appropriate OS config file to enable Safari, Edge, vimpirator &etc.
#define BABL_APP // Application specific settings this has sub-options.
#define BABL_APP_CELLS // spreadsheets and tables
#define BABL_APP_EDITOR // Fancy editor commands
#define BABL_APP_EDITOR // Fancy editor commands
#define BABL_APP_WINDOWSPLITTING // splitting frames & windows

//All OSes
Expand Down
15 changes: 12 additions & 3 deletions users/miles2go/keymaps/handwired/ms_sculpt_mobile/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#define RGBLIGHT_COLOR_VI 0x00,0x90,0x00
#define RGBLIGHT_COLOR_READMUX 0x33,0xFF,0x33 // green screen
#define RGBLIGHT_COLOR_CHROMEOS 0xf4,0xc2,0xd // google yellows
#endif
#endif

#endif // bablpaste

Expand All @@ -29,8 +29,17 @@
#define RGBLIGHT_COLOR_LAYER_2 0xFF, 0x00, 0x00 // symbol
#define RGBLIGHT_COLOR_LAYER_3 0x00, 0xFF, 0xFF // move
#define RGBLIGHT_COLOR_LAYER_4 0xFF, 0x00, 0xFF // delmove
#define RGBLIGHT_COLOR_LAYER_5 0x00, 0xFF, 0xFF
#define RGBLIGHT_ANIMATIONS
#define RGBLIGHT_COLOR_LAYER_5 0x00, 0xFF, 0xFF
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
#define RGBLIGHT_EFFECT_SNAKE
#define RGBLIGHT_EFFECT_KNIGHT
#define RGBLIGHT_EFFECT_CHRISTMAS
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_RGB_TEST
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGB_LIGHT_EFFECT_BREATHE_MAX 200
#define RGBLIGHT_RAINBOW_SWIRL_RANGE 127
#endif // rgblight
Expand Down
2 changes: 1 addition & 1 deletion users/mtei/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#pragma once

// Selection of RGBLIGHT MODE to use.
#undef RGBLIGHT_ANIMATIONS
#undef RGBLIGHT_EFFECT_BREATHING
#undef RGBLIGHT_EFFECT_RAINBOW_MOOD
#undef RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand All @@ -16,6 +15,7 @@
#undef RGBLIGHT_EFFECT_STATIC_GRADIENT
#undef RGBLIGHT_EFFECT_RGB_TEST
#undef RGBLIGHT_EFFECT_ALTERNATING
#undef RGBLIGHT_EFFECT_TWINKLE

#if defined(LED_ANIMATIONS)
# if LED_ANIMATIONS_LEVEL > 1
Expand Down
1 change: 0 additions & 1 deletion users/muppetjones/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#pragma once

#ifdef RGBLIGHT_ENABLE
// # define RGBLIGHT_ANIMATIONS
# define RGBLIGHT_HUE_STEP 8
# define RGBLIGHT_SAT_STEP 16
# define RGBLIGHT_VAL_STEP 16
Expand Down
1 change: 0 additions & 1 deletion users/muppetjones/readme/rgblayers.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ This bit of code allows you to define layer lighting that respects your current

```
#ifdef RGBLIGHT_ENABLE
// # define RGBLIGHT_ANIMATIONS
# define RGBLIGHT_HUE_STEP 8
# define RGBLIGHT_SAT_STEP 16
# define RGBLIGHT_VAL_STEP 16
Expand Down
Loading