Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QP driver init functions weak. #18717

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Oct 14, 2022

Description

Allows keyboards to override the init sequence for each driver, potentially opening up support for slightly different panels.
Will need to be on top of custom implementations to check that they don't get copypasta'd everywhere -- in that case we should formalise the process by punting the sequence into core.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team October 14, 2022 12:45
@github-actions github-actions bot added the core label Oct 14, 2022
@drashna drashna requested a review from a team October 14, 2022 17:10
@zvecr zvecr merged commit 19aed5e into qmk:develop Oct 14, 2022
@tzarc tzarc deleted the weak-qp-init-funcs branch October 14, 2022 22:40
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants