Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

led_update_kb -> led_update_ports where appropriate #18716

Merged
merged 1 commit into from
Oct 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions keyboards/dk60/dk60.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,10 @@ void led_init_ports(void) {
setPinOutput(F0);
}

bool led_update_kb(led_t led_state) {
if (led_update_user(led_state)) {
if (led_state.caps_lock) {
dk60_caps_led_on();
} else {
dk60_caps_led_off();
}
void led_update_ports(led_t led_state) {
if (led_state.caps_lock) {
dk60_caps_led_on();
} else {
dk60_caps_led_off();
}

return true;
}
12 changes: 4 additions & 8 deletions keyboards/dp60/keymaps/indicator/indicator.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,10 @@ void rgblight_call_driver(LED_TYPE *start_led, uint8_t num_leds)
indicator_write(start_led + (RGBLED_NUM - RGB_INDICATOR_NUM), RGB_INDICATOR_NUM);
}

bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if (res) {
rgblight_set_layer_state(0, led_state.caps_lock);
rgblight_set_layer_state(1, led_state.scroll_lock);
rgblight_set_layer_state(2, led_state.num_lock);
}
return res;
void led_update_ports(led_t led_state) {
rgblight_set_layer_state(0, led_state.caps_lock);
rgblight_set_layer_state(1, led_state.scroll_lock);
rgblight_set_layer_state(2, led_state.num_lock);
}

layer_state_t layer_state_set_kb(layer_state_t state) {
Expand Down
12 changes: 4 additions & 8 deletions keyboards/fallacy/fallacy.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,8 @@ void matrix_scan_kb(void) {

/* update LED driver with usb led_state
*/
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if(res) {
set_fallacy_led(2, led_state.caps_lock); /* caps */
set_fallacy_led(1, led_state.num_lock); /* num lock */
set_fallacy_led(0, led_state.scroll_lock); /* scroll lock */
}
return res;
void led_update_ports(led_t led_state) {
set_fallacy_led(2, led_state.caps_lock); /* caps */
set_fallacy_led(1, led_state.num_lock); /* num lock */
set_fallacy_led(0, led_state.scroll_lock); /* scroll lock */
}
4 changes: 1 addition & 3 deletions keyboards/iron180/iron180.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#include "iron180.h"

#ifdef CAPSLOCK_BACKLIGHT
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
void led_update_ports(led_t led_state) {
if (!led_state.caps_lock){
if (is_backlight_breathing()) breathing_disable();
backlight_disable();
Expand All @@ -28,6 +27,5 @@ bool led_update_kb(led_t led_state) {
if (is_backlight_breathing()) breathing_enable();
backlight_enable();
}
return res;
}
#endif
14 changes: 5 additions & 9 deletions keyboards/kc60/kc60.c
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
#include "kc60.h"

bool led_update_kb(led_t led_state) {
if (led_update_user(led_state)) {
if (led_state.caps_lock) {
setPinOutput(B2);
} else {
setPinInput(B2);
}
void led_update_ports(led_t led_state) {
if (led_state.caps_lock) {
setPinOutput(B2);
} else {
setPinInput(B2);
}

return true;
}
14 changes: 5 additions & 9 deletions keyboards/metamechs/timberwolf/timberwolf.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,12 @@

#include "timberwolf.h"

bool led_update_kb(led_t led_state) {
bool runDefault = led_update_user(led_state);
if(runDefault) {
if (led_state.caps_lock) {
backlight_level_noeeprom(get_backlight_level());
} else {
backlight_set(0);
}
void led_update_ports(led_t led_state) {
if (led_state.caps_lock) {
backlight_level_noeeprom(get_backlight_level());
} else {
backlight_set(0);
}
return runDefault;
}

bool encoder_update_kb(uint8_t index, bool clockwise) {
Expand Down
8 changes: 2 additions & 6 deletions keyboards/moonlander/moonlander.c
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,8 @@ const uint8_t music_map[MATRIX_ROWS][MATRIX_COLS] = LAYOUT_moonlander(
#endif

#ifdef CAPS_LOCK_STATUS
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if(res) {
ML_LED_6(led_state.caps_lock);
}
return res;
void led_update_ports(led_t led_state) {
ML_LED_6(led_state.caps_lock);
}
#endif

Expand Down
14 changes: 5 additions & 9 deletions keyboards/novelkeys/nk65/nk65.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,12 @@
* Middle LED is blue and red. LED driver 2 RGB 6 Red and Blue channel
* Bottom LED is red only LED driver 2 RGB 6 Green channel.
*/
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if(res) {
if (led_state.caps_lock) {
IS31FL3733_set_color( 7+64-1, 0, 255, 0 );
} else {
IS31FL3733_set_color( 7+64-1, 0, 0, 0 );
}
void led_update_ports(led_t led_state) {
if (led_state.caps_lock) {
IS31FL3733_set_color( 7+64-1, 0, 255, 0 );
} else {
IS31FL3733_set_color( 7+64-1, 0, 0, 0 );
}
return res;
}

__attribute__((weak)) layer_state_t layer_state_set_user(layer_state_t state) {
Expand Down
8 changes: 2 additions & 6 deletions keyboards/nullbitsco/nibble/nibble.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
#include QMK_KEYBOARD_H

// Use Bit-C LED to show CAPS LOCK status
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if (res) {
set_bitc_LED(led_state.caps_lock ? LED_DIM : LED_OFF);
}
return res;
void led_update_ports(led_t led_state) {
set_bitc_LED(led_state.caps_lock ? LED_DIM : LED_OFF);
}
8 changes: 2 additions & 6 deletions keyboards/nullbitsco/tidbit/tidbit.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,8 @@ bool encoder_update_kb(uint8_t index, bool clockwise) {
}

// Use Bit-C LED to show NUM LOCK status
bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if (res) {
set_bitc_LED(led_state.num_lock ? LED_DIM : LED_OFF);
}
return res;
void led_update_ports(led_t led_state) {
set_bitc_LED(led_state.num_lock ? LED_DIM : LED_OFF);
}

bool process_record_kb(uint16_t keycode, keyrecord_t *record) {
Expand Down
10 changes: 3 additions & 7 deletions keyboards/viendi8l/viendi8l.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,9 @@ uint8_t caps_color[3] = {0xFF,0xFF,0xFF};
uint8_t num_color[3] = {0xFF,0xFF,0xFF};
uint8_t layer_color[3] = {0xFF,0xFF,0xFF};

bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if(res) {
led_state.caps_lock ? rgblight_setrgb_at(caps_color[0], caps_color[1], caps_color[2], 2) : rgblight_setrgb_at(0x00,0x00,0x00,2);
led_state.num_lock ? rgblight_setrgb_at(num_color[0], num_color[1], num_color[2], 3) : rgblight_setrgb_at(0x00,0x00,0x00,3);
}
return res;
void led_update_ports(led_t led_state) {
led_state.caps_lock ? rgblight_setrgb_at(caps_color[0], caps_color[1], caps_color[2], 2) : rgblight_setrgb_at(0x00,0x00,0x00,2);
led_state.num_lock ? rgblight_setrgb_at(num_color[0], num_color[1], num_color[2], 3) : rgblight_setrgb_at(0x00,0x00,0x00,3);
}

layer_state_t layer_state_set_kb(layer_state_t state) {
Expand Down
16 changes: 5 additions & 11 deletions keyboards/weirdo/ls_60/ls_60.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,10 @@
#include "ls_60.h"


bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);

if (res) {
if(led_state.caps_lock){
rgblight_setrgb_at(192, 192, 192, 0);
} else {
rgblight_setrgb_at(0, 0, 0, 0);
}
void led_update_ports(led_t led_state) {
if(led_state.caps_lock){
rgblight_setrgb_at(192, 192, 192, 0);
} else {
rgblight_setrgb_at(0, 0, 0, 0);
}

return res;
}
16 changes: 6 additions & 10 deletions keyboards/yiancardesigns/seigaiha/seigaiha.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@

uint8_t send_data = 0x00;

bool led_update_kb(led_t led_state) {
bool res = led_update_user(led_state);
if(res) {
if (led_state.caps_lock){
send_data |= 1 << 5;
} else {
send_data &= ~(1 << 5);
}
i2c_writeReg((PORT_EXPANDER_ADDRESS << 1), 0x0A, &send_data, 1, 20);
void led_update_ports(led_t led_state) {
if (led_state.caps_lock){
send_data |= 1 << 5;
} else {
send_data &= ~(1 << 5);
}
return res;
i2c_writeReg((PORT_EXPANDER_ADDRESS << 1), 0x0A, &send_data, 1, 20);
}

__attribute__((weak)) layer_state_t layer_state_set_user(layer_state_t state) {
Expand Down