Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup keychron/q3 #18687

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Fixup keychron/q3 #18687

merged 5 commits into from
Oct 13, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Oct 12, 2022 •
edited
Loading

Description

As title — to align with develop specific changes.
Also changes rgb_matrix_indicators_advanced_user -> rgb_matrix_indicators_advanced_kb
Unsure what KC_INT1PT(N) was, so changed to KC_INT1

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Oct 12, 2022
@tzarc
Copy link
Member

tzarc commented Oct 12, 2022

There are a few cases where KC_ROPT and KC_ROPTN have potentially been changed incorrectly, probably should rectify that.

fauxpark
fauxpark requested changes Oct 12, 2022
View reviewed changes
keyboards/keychron/q3/jis_encoder/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q3/jis_encoder/keymaps/keychron/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q3/jis_encoder/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q3/jis/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q3/jis/keymaps/keychron/keymap.c Outdated Show resolved Hide resolved
keyboards/keychron/q3/jis/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@waffle87
Copy link
Member Author

Thanks fauxpark

@fauxpark fauxpark requested a review from a team October 13, 2022 00:50
@tzarc tzarc merged commit 3f4fd85 into qmk:develop Oct 13, 2022
@waffle87 waffle87 deleted the fix/led_num branch October 13, 2022 03:13
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @fauxpark @ramonimbao
Fixup keychron/q3 (qmk#18687)
7fe6da9 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @tzarc @fauxpark