-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial DD keycode migration #18643
Initial DD keycode migration #18643
Conversation
Current Allocations:
SAFE_RANGE currently maps to both keyboard+keymap - keyboard refactoring can happen at a later date
|
4995e36
to
18a484d
Compare
18a484d
to
64ca5d3
Compare
@fauxpark could you have a look at the allocated ranges and flag any potential issues or recommendations please. |
c536da9
to
ae319be
Compare
27fdcc7
to
bed4c19
Compare
bed4c19
to
010501d
Compare
This looks fantastic; huge improvement over the old disorganized keycode enums. While the keycodes are changing though, might it be worth taking the opportunity to sort a few? Like, the magic swap/unswap/toggle keycodes for each option could be grouped together. |
914120a
to
500ed3a
Compare
e2456ee
to
aadf4cd
Compare
VIA has been updated to use these new int values, still to do is the refactoring to the changed keycode names and adding new keycodes to the UI. |
* Initial DD keycode migration * Sort magic keycodes
* Initial DD keycode migration * Sort magic keycodes
Description
Initial pass covers:
Due to the tight coupling in the code base, currently it has been chosen to not simultaneously support the current keycode values as a "legacy" version.
TODO
data/constants/keycodes/
folder?data/constants/keycodes/0.0.1/
folder for each version?Future
keycode(with_args)
Types of Changes
Issues Fixed or Closed by This PR
Checklist