Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy international keycodes #18588

Merged
merged 14 commits into from
Oct 9, 2022
Merged

Remove legacy international keycodes #18588

merged 14 commits into from
Oct 9, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 4, 2022

Description

Where the appropriate keymap_*.h header was not included (which turns out to be most of the time), the generic keycode name was used eg. KC_RO -> KC_INT1.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 4, 2022
@fauxpark fauxpark requested a review from a team October 4, 2022 17:36
@drashna drashna requested a review from a team October 5, 2022 01:32
@fauxpark fauxpark mentioned this pull request Oct 5, 2022
Merged
14 tasks
@fauxpark
Copy link
Member Author

fauxpark commented Oct 6, 2022

Remaining build failures are unrelated.

@fauxpark fauxpark merged commit 4b2d71d into qmk:develop Oct 9, 2022
@fauxpark fauxpark deleted the intl-keycodes-legacy-remove branch October 9, 2022 03:51
@fauxpark fauxpark mentioned this pull request Oct 10, 2022
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request Nov 16, 2022
Merged
14 tasks
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Remove legacy international keycodes (qmk#18588)
170af5a
jpskenn pushed a commit to jpskenn/qmk_firmware that referenced this pull request Nov 1, 2023
Remove legacy international keycodes (qmk#18588)
27dcd83
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 1, 2023
@jpskenn
Revert "Remove legacy international keycodes (qmk#18588)"
4e9b78d 
This reverts commit 27dcd83.
jpskenn pushed a commit to jpskenn/qmk_firmware that referenced this pull request Nov 2, 2023
Remove legacy international keycodes (qmk#18588)
b887455
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 4, 2023
@jpskenn
Remove legacy international keycodes (qmk#18588)
6ff2924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna