Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more host code (programmable button & digitizer) #18565

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 2, 2022

Description

Removing programmable button from host_driver_t (to match digitizer and joystick) and hoisting report assembly out of USB drivers.

Eventual goal is to replace the host_driver_t's send_keyboard, send_mouse and send_extra with a single send_report which takes endpoint number, pointer to report, and size.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 2, 2022 03:50
@drashna drashna requested a review from a team October 2, 2022 06:52
@fauxpark fauxpark merged commit 09d3e27 into qmk:develop Oct 4, 2022
@fauxpark fauxpark deleted the programmable-button-send-refactor branch October 4, 2022 22:19
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants