Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment of CM_QUES (Colemak question mark) #18557

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Fix comment of CM_QUES (Colemak question mark) #18557

merged 1 commit into from
Oct 1, 2022

Conversation

precondition
Copy link
Contributor

Description

#define CM_QUES S(CM_SLSH) // / → #define CM_QUES S(CM_SLSH) // ?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization (Better comment)
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • (Indirectly) incorrect label for the Colemak OS keyboard layout on the QMK configurator

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@precondition
Fix comment of CM_QUES (Colemak question mark)
6d0470f 
`#define CM_QUES S(CM_SLSH) // /` → `#define CM_QUES S(CM_SLSH) // ?`
@github-actions github-actions bot added the core label Oct 1, 2022
@fauxpark fauxpark requested a review from a team October 1, 2022 08:29
@noroadsleft noroadsleft merged commit e78fa1f into qmk:develop Oct 1, 2022
@noroadsleft
Copy link
Member

Thanks!

@precondition precondition deleted the colemak_question branch October 5, 2022 07:56
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@precondition @ramonimbao
Fix comment of CM_QUES (Colemak question mark) (qmk#18557)
07c76e7 
`#define CM_QUES S(CM_SLSH) // /` → `#define CM_QUES S(CM_SLSH) // ?`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @noroadsleft @fauxpark