Fix retain brightness when val is changed while a layer is active #18426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spidey3
requested changes
Sep 19, 2022
| rgblight_status.base_mode = mode_base_table[rgblight_config.mode]; | ||
| if (rgblight_config.mode == RGBLIGHT_MODE_STATIC_LIGHT) { | ||
| // same static color | ||
| LED_TYPE tmp_led; | ||
| #ifdef RGBLIGHT_LAYERS_RETAIN_VAL |
There was a problem hiding this comment.
I think similar code is needed in the RGBLIGHT_MODE_STATIC_GRADIENT case below, at line 580...
There was a problem hiding this comment.
You're right, RGBLIGHT_MODE_STATIC_GRADIENT needs it too
|
I've made the requested changes and tested it with |
drashna
approved these changes
Sep 24, 2022
spidey3
approved these changes
Sep 28, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
…k#18426) * Fix retain brightness when val is changed while a layer is active * Fix retain brightness for RGBLIGHT_MODE_STATIC_GRADIENT * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
RGBLIGHT_LAYERS_RETAIN_VALis defined while lighting layers are used,rgblight_layers_write()checksrgblight_config.valfor the currently set brightness. However,rgblight_sethsv_eeprom_helper()updatesrgblight_config.valwith the newvalafter it callsrgblight_setrgb(), which ultimately callsrgblight_layers_write(). This means that if the brightness is changed while a lighting layer is active, the LEDs won't change to the new brightness until the lighting layer changes, or the HSV is changed again.Tested with Iris Rev. 3
Types of Changes
Issues Fixed or Closed by This PR
Checklist