Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EECONFIG_KEYMAP_UPPER_BYTE init #18394

Merged
merged 2 commits into from
Sep 17, 2022
Merged

Fix EECONFIG_KEYMAP_UPPER_BYTE init #18394

merged 2 commits into from
Sep 17, 2022

Conversation

daskygit
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 17, 2022
@daskygit @drashna
Add comment
2ec86bd 
Co-authored-by: Drashna Jaelre <[email protected]>
@daskygit daskygit merged commit db6a637 into qmk:develop Sep 17, 2022
@daskygit daskygit deleted the fix/upper_byte_init branch September 17, 2022 19:58
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@daskygit @drashna @ramonimbao
Fix EECONFIG_KEYMAP_UPPER_BYTE init (qmk#18394)
72a6f3c 
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @spidey3