Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fake EE_HANDS from EEPROM init. #18352

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

daskygit
Copy link
Member

Description

Moves and adds some logic so fake EE_HANDS no longer requires a EEPROM init.

Triggering a EEPROM init can be a pain with split keyboards that make use of _RIGHT defines for the matrix. This also emulates AVR better when flashing with left/right bootloader targets.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Sep 13, 2022
@drashna drashna requested review from zvecr and a team September 13, 2022 17:56
@zvecr zvecr merged commit e1aed8d into qmk:develop Sep 15, 2022
@daskygit daskygit deleted the pr/move_fake_eehands branch September 18, 2022 00:31
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants