Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeonWorks Frog Mini Hotswap Layout Rework #18305

Merged
merged 9 commits into from
Sep 7, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • physically arranges LAYOUT_all macro and keymaps
    With this change, the keycode for the right half of a Split Backspace is now at the end of the top row, instead of at the end of the bottom row.
  • renames LAYOUT_all to LAYOUT_60_tsangan_hhkb
  • adds LAYOUT_60_ansi_tsangan, LAYOUT_60_hhkb, LAYOUT_60_ansi_wkl and LAYOUT_60_ansi_wkl_split_bs_rshift macros
  • enable Community Layouts support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 7, 2022
@noroadsleft noroadsleft requested a review from a team September 7, 2022 18:22
@noroadsleft
Copy link
Member Author

cc @Gondolindrim (keyboard maintainer)

@noroadsleft noroadsleft merged commit ce90be0 into qmk:master Sep 7, 2022
@noroadsleft noroadsleft deleted the rf/geonworks_frogmini_fmh branch September 7, 2022 21:30
csrazvan added a commit to csrazvan/qmk_firmware that referenced this pull request Sep 8, 2022
* upstream/master: (451 commits)
  Add Iris Rev. 6b (qmk#18307)
  GeonWorks Frog Mini Hotswap Layout Rework (qmk#18305)
  Update Iris VIA configuration (qmk#18306)
  [Keyboard] Wearhaus66 correct matrix (qmk#18284)
  enable RGB matrix effects for drop ctrl (qmk#18291)
  [Keymap] removed else in numlock led if statement (qmk#18304)
  added a new kprepublic/bm40hsrgb keymap called dan (qmk#18301)
  Delete my keymaps (qmk#18302)
  keymaps/stapelberg: keypad layer for multimedia keys, wake on escape (qmk#18295)
  Fungo rev1: fix QMK Configurator key sequence (qmk#18293)
  Discourage use of ENCODER_MAP at keyboard level (qmk#18286)
  Mars 6.5 Layout Additions (qmk#18282)
  Remove use of legacy keycode (qmk#18281)
  EU ISOlation: fix QMK Configurator key sequence (qmk#18272)
  Fix compilation error for GH60 satan HHKB 7u layout (qmk#18250)
  dyz60_hs Layout Additions (qmk#18261)
  Fix a couple of boards still using `usb.device_ver` (qmk#18258)
  Clean up data driven mappings syntax (qmk#18257)
  [Docs] Update 'Process Record' according to the code (qmk#18209)
  [Keyboard] RS60 Rev2 change to eeprom emulation (qmk#18201)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* fmh.h: add matrix diagram

* info.json: apply friendly formatting

* physically arrange LAYOUT_all macro

Move position `K5D` (right half of Split Backspace) to the end of the top row.

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_hhkb

* add LAYOUT_60_ansi_wkl

* add LAYOUT_60_ansi_wkl_split_bs_rshift

* enable Community Layouts support
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* fmh.h: add matrix diagram

* info.json: apply friendly formatting

* physically arrange LAYOUT_all macro

Move position `K5D` (right half of Split Backspace) to the end of the top row.

* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_hhkb

* add LAYOUT_60_ansi_wkl

* add LAYOUT_60_ansi_wkl_split_bs_rshift

* enable Community Layouts support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants