-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elite-Pi converter #18236
Add Elite-Pi converter #18236
Conversation
Co-authored-by: Joel Challis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also while i remember, does the Elite-Pi have vbus detection?
Should probably also add a "CONVERT_FROM=elite_c" option too. |
Co-authored-by: Joel Challis <[email protected]>
@drashna - why have a CONVERT_FROM parameter... there is only one option to convert from? This is fixed hardware with a fixed footprint and pinout. It's an unnecessary parameter. Just do right by the hardware. This is the same argument and issue I'm struggling with for #18239 |
What's wrong with considering these converters to be a general "convert from AVR" tool? |
Because pinout matters. trying to run this on something that uses an AVR teensy just wouldnt give the expected result.
This is kind of what the |
Co-authored-by: Joel Challis <[email protected]>
Description
Add converter for Elite-Pi controller board
Pinout reference:
Types of Changes
Issues Fixed or Closed by This PR
Checklist