Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify extrakeys sending at the host driver level #18230

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Simplify extrakeys sending at the host driver level #18230

merged 4 commits into from
Sep 2, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Aug 31, 2022 •
edited
Loading

Description

Should make it a bit easier to tack on the Telephony page to the extrakeys report descriptor, for its microphone mute usage.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 31, 2022 07:28
@fauxpark fauxpark force-pushed the send-extra-generic branch from b47c408 to 1d33ada Compare August 31, 2022 07:28
@fauxpark fauxpark marked this pull request as ready for review August 31, 2022 07:50
drashna
drashna approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break anything, at least.

@drashna drashna requested a review from a team August 31, 2022 14:29
@zvecr zvecr merged commit 09d668e into qmk:develop Sep 2, 2022
@fauxpark fauxpark deleted the send-extra-generic branch September 2, 2022 19:43
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Simplify extrakeys sending at the host driver level (qmk#18230)
be48ebe 
* Simplify extrakeys sending at the host driver level

* There are two arguments here

* Wrong syntax

* Adjust keyboards which use a custom host driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr