Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointing device support to data driven config #18215

Merged
merged 12 commits into from
Nov 13, 2022
Merged

Add pointing device support to data driven config #18215

merged 12 commits into from
Nov 13, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 30, 2022 •
edited
Loading

Description

First attempt at adding support for data driven config.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Aug 30, 2022
@drashna drashna requested a review from a team August 30, 2022 06:14
KarlK90
KarlK90 requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, found a duplication in the mapping defines which seems bogus.

data/schemas/keyboard.jsonschema Outdated Show resolved Hide resolved
KarlK90
KarlK90 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna drashna requested a review from a team August 30, 2022 20:20
@drashna drashna force-pushed the dd/pointing_device branch from ed133c8 to 3dfd539 Compare August 31, 2022 14:17
Kriechi
Kriechi reviewed Sep 3, 2022
View reviewed changes
data/mappings/info_config.json Outdated
@@ -92,6 +103,7 @@
"SECURE_IDLE_TIMEOUT": {"info_key": "secure.idle_timeout", "value_type": "int"},
"SENDSTRING_BELL": {"info_key": "audio.macro_beep", "value_type": "bool"},
"SPLIT_MODS_ENABLE": {"info_key": "split.transport.sync_modifiers", "value_type": "bool"},
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this to fit into the transport options - or how would you distinguish these here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, fair.

Suggested change
"SPLIT_POINTING_ENABLE": {"info_key": "split.pointing_device.enabled", "value_type": "bool"},
"SPLIT_POINTING_ENABLE": {"info_key": "split.transport.sync_pointing", "value_type": "bool"},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split.transport.sync_pointing_device ?
though I'm not sure what is actually synced - but all other options use _DEVICE_ as part of the name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm horrible at naming...

Not sure if it's better to use the full "pointing device" as per the other features, or keep it closer to what the other transport.sync_* names are for consistency (with both naming in the info.json and config.h stuff)

@drashna drashna requested a review from a team September 17, 2022 17:30
fauxpark
fauxpark requested changes Sep 26, 2022
View reviewed changes
lib/python/qmk/cli/generate/config_h.py Outdated Show resolved Hide resolved
@tzarc tzarc merged commit d3073ef into qmk:develop Nov 13, 2022
@drashna drashna deleted the dd/pointing_device branch November 13, 2022 18:12
drashna added a commit to drashna/qmk_firmware that referenced this pull request Nov 13, 2022
@drashna
Revert "Add pointing device support to data driven config (qmk#18215)"
fb7bc53 
This reverts commit d3073ef.
tzarc pushed a commit that referenced this pull request Nov 15, 2022
@drashna
Revert "Add pointing device support to data driven config (#18215)" (#…
1a3f213 
…19063)
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @zvecr @ramonimbao
Add pointing device support to data driven config (qmk#18215)
517bc56 
Co-authored-by: Joel Challis <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @ramonimbao
Revert "Add pointing device support to data driven config (qmk#18215)" (
1fdd606 
qmk#19063)
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@drashna @zvecr @elpekenin
Add pointing device support to data driven config (qmk#18215)
335ddd0 
Co-authored-by: Joel Challis <[email protected]>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@drashna @elpekenin
Revert "Add pointing device support to data driven config (qmk#18215)" (
a29a83e 
qmk#19063)
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@drashna @zvecr @crembz
Add pointing device support to data driven config (qmk#18215)
52f33b7 
Co-authored-by: Joel Challis <[email protected]>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@drashna @crembz
Revert "Add pointing device support to data driven config (qmk#18215)" (
dc00878 
qmk#19063)
@Kriechi Kriechi mentioned this pull request Jan 25, 2023
Closed
14 tasks
Kriechi pushed a commit to Kriechi/qmk_firmware that referenced this pull request Apr 17, 2023
@drashna @Kriechi
Add pointing device support to data driven config
6cee809 
resurrected and squashed from qmk#18215
@Kriechi Kriechi mentioned this pull request Aug 5, 2023
Closed
14 tasks
Kriechi pushed a commit to Kriechi/qmk_firmware that referenced this pull request Aug 17, 2023
@drashna @Kriechi
Add pointing device support to data driven config
49c6103 
resurrected and squashed from qmk#18215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@Kriechi Kriechi Kriechi left review comments

@fauxpark fauxpark fauxpark requested changes

@KarlK90 KarlK90 KarlK90 approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drashna @Kriechi @tzarc @fauxpark @KarlK90 @zvecr