qmk new-keyboard: Add default bootloader for RP2040
#18161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `rp2040` instead of `custom` when MCU is `RP2040`. NOTE: This was already working for `kb2040` and `promicro_rp2040` as they derive their bootloader from `data/mappings/defaults.json`. However, if you selected `RP2040` as MCU then you would end up with `custom`, which I'm not sure is ever useful.
|
Already fixed by #18100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
rp2040instead ofcustomwhen MCU isRP2040.NOTE: This was already working for
kb2040andpromicro_rp2040asthey derive their bootloader from
data/mappings/defaults.json.However, if you selected
RP2040as MCU then you would end up withcustom, which I'm not sure is ever useful.