Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert some WB32 specific changes #18038

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Partially revert some WB32 specific changes #18038

merged 1 commit into from
Aug 14, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 14, 2022 •
edited
Loading

Description

Didnt allow them on previous driver changes, so should this time either.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team August 14, 2022 15:59
@github-actions github-actions bot added CI cli qmk cli command core dependencies documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Aug 14, 2022
@zvecr zvecr changed the base branch from master to develop August 14, 2022 16:00
@zvecr zvecr added bug breaking_change_2022q3 and removed keyboard keymap documentation python cli qmk cli command translation via Adds via keymap and/or updates keyboard for via support CI dependencies labels Aug 14, 2022
@drashna drashna requested a review from a team August 14, 2022 16:25
@zvecr zvecr merged commit 463fb72 into qmk:develop Aug 14, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Partially revert some WB32 specific changes (qmk#18038)
798adb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @drashna