Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add high-density STM32F103RC support #18035

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add high-density STM32F103RC support #18035

wants to merge 7 commits into from
+189 −0

Conversation

HorrorTroll
Copy link
Contributor

@HorrorTroll HorrorTroll commented Aug 14, 2022 •
edited
Loading

Description

Add high-density STM32F103RC support for "STM32 Mini V2 Development Kit" board, in case you want to using for experiment thing if you couldn't find any "Bluepill STM32F103C8" and it cheap.

The EEPROM emulation support is not included, as it have built-in SPI Flash 2M-Bit W25Q16JVSIQ already. So by default this board will be using wear_leveling driver on SPI Flash.

Tested onekey keymaps:

  • default
  • adc (needs changes in halconf.h and mcuconf.h to enable ADC)
  • backlight
  • console
  • digitizer (not tested yet)
  • eep_rst (with EEPROM_DRIVER=transient this just restarts the firmware)
  • hardware_id
  • oled (needs changes in halconf.h and mcuconf.h to enable I2C)
  • quine (not tested yet)
  • reboot (works appropriately with stm32duino — the bootloader does not appear during the reboot)
  • reset (works appropriately with stm32duino — the bootloader starts with the 8s timeout disabled)
  • rgb (not tested yet)
  • rgb_matrix (needs -e RGB_MATRIX_DRIVER=WS2812 -e CONSOLE_ENABLE=no)

This is my first time open these kind pr, so I would like to have a proper reviewer code. Thanks!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 14, 2022
zvecr
zvecr requested changes Aug 14, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes, platforms and handwired/onekey, should be split out from the keyboard updates.

@HorrorTroll
Copy link
Contributor Author

Thanks, lemme split that up right away

@github-actions github-actions bot removed keymap via Adds via keymap and/or updates keyboard for via support labels Aug 15, 2022
@HorrorTroll HorrorTroll mentioned this pull request Aug 15, 2022
Merged
14 tasks
@HorrorTroll HorrorTroll changed the title Add high-density STM32F103RC support and refactor Handwired K552 keyboard Add high-density STM32F103RC support Aug 15, 2022
@HorrorTroll
Copy link
Contributor Author

Done, just split the pr to #18066. Feel free to review again, thanks!

@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 16, 2022
@tzarc tzarc requested a review from a team October 16, 2022 06:47
fauxpark
fauxpark requested changes Oct 16, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs conversion to info.json.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2022
@HorrorTroll
Copy link
Contributor Author

I'm just done it, if u have free time. Can u take a look?

@HorrorTroll HorrorTroll requested a review from fauxpark October 21, 2022 08:26
@drashna drashna requested a review from a team October 25, 2022 05:58
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 10, 2022
@HorrorTroll HorrorTroll mentioned this pull request Dec 31, 2022
Merged
8 tasks
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jan 9, 2023
@HorrorTroll
Copy link
Contributor Author

HorrorTroll commented Jan 9, 2023 •
edited
Loading

Ehh, sorry but this PR still active and waiting for reviewing

@tzarc tzarc reopened this Jan 10, 2023
@tzarc tzarc removed the stale Issues or pull requests that have become inactive without resolution. label Jan 10, 2023
noroadsleft
noroadsleft requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit out of my depth when it comes to ChibiOS configs, but nothing here seems glaringly wrong to my eyes.

platforms/chibios/boards/STM32_F103_STM32DUINO/ld/STM32F103xC_stm32duino_bootloader.ld Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot use BOOTLOADER = stm32duino due to the need to override
MCU_LDSCRIPT, therefore all parameters need to be specified here manually.

This workaround is no longer required.

keyboards/handwired/onekey/stm32_mini_v2/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/onekey/stm32_mini_v2/info.json Show resolved Hide resolved
platforms/chibios/boards/STM32_F103_STM32DUINO/ld/STM32F103xC_stm32duino_bootloader.ld Outdated Show resolved Hide resolved
@HorrorTroll
Copy link
Contributor Author

Done, if anyone have times. Can i have a re-review on this PR?

@HorrorTroll
Copy link
Contributor Author

Done, thanks

@HorrorTroll
Copy link
Contributor Author

I'm sorry, the PR seem to be long active anyway. Can i have a re-review this one? Thanks

fauxpark
fauxpark requested changes Oct 7, 2023
View reviewed changes
keyboards/handwired/onekey/stm32_mini_v2/rules.mk
Comment on lines +4 to +6
# Enter lower-power sleep mode when on the ChibiOS idle thread
OPT_DEFS += -DCORTEX_ENABLE_WFI_IDLE=TRUE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Enter lower-power sleep mode when on the ChibiOS idle thread
OPT_DEFS += -DCORTEX_ENABLE_WFI_IDLE=TRUE

keyboards/handwired/onekey/stm32_mini_v2/config.h
Comment on lines +40 to +44
#ifdef BACKLIGHT_ENABLE
/* Backlight config */
#define BACKLIGHT_PWM_DRIVER PWMD2
#define BACKLIGHT_PWM_CHANNEL 1
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ifdef BACKLIGHT_ENABLE
/* Backlight config */
#define BACKLIGHT_PWM_DRIVER PWMD2
#define BACKLIGHT_PWM_CHANNEL 1
#endif
/* Backlight config */
#define BACKLIGHT_PWM_DRIVER PWMD2
#define BACKLIGHT_PWM_CHANNEL 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark requested changes

Assignees
No one assigned
Labels
awaiting review core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HorrorTroll @fauxpark @zvecr @noroadsleft @tzarc