Bandominedoni version output feature and a new keymap added #17947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keymap
via
drashna
reviewed
Aug 8, 2022
| @@ -28,6 +29,10 @@ enum layer_names { | |||
| _FN | |||
| }; | |||
|
|
|||
| enum custom_keycodes { | |||
| VERSION = SAFE_RANGE | |||
There was a problem hiding this comment.
This would allow you to list it in VIA
Suggested change
| VERSION = SAFE_RANGE | |
| VERSION = USER00 |
There was a problem hiding this comment.
Wow! That’s cool. We’ve been waiting for such a feature on VIA!
I’ll update my codes as you suggested.
It seems you can use this as long as you have 16 or less custom codes.
https://github.com/qmk/qmk_firmware/blob/master/quantum/via.h
drashna
approved these changes
Aug 8, 2022
keyboard-magpie
approved these changes
Aug 13, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
* SPLIT_USB_DETECT added. * lednotg keymap added. * lednotg missing modification fixed. * VERSION is available. * USER00 is used instead of SAFE_RANGE in via/keymap.c
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* SPLIT_USB_DETECT added. * lednotg keymap added. * lednotg missing modification fixed. * VERSION is available. * USER00 is used instead of SAFE_RANGE in via/keymap.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A feature to output the name of the keyboard, keymap, QMK version, and the build date is added.
Types of Changes
Issues Fixed or Closed by This PR
Checklist