Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with #17904. #17905

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix issue with #17904. #17905

merged 1 commit into from
Aug 4, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 4, 2022

Description

Error with #17904.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team August 4, 2022 11:53
@tzarc tzarc changed the title Whoops. Fix issue with #17904. Aug 4, 2022
@github-actions github-actions bot added the core label Aug 4, 2022
KarlK90
KarlK90 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles fine on my end

@tzarc tzarc merged commit d9eb152 into qmk:develop Aug 4, 2022
@tzarc tzarc deleted the fixup-format-strings-take2 branch August 4, 2022 12:15
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@tzarc @nolanseaton
Fix issue with qmk#17904. (qmk#17905)
66c0ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @KarlK90