YaMseK: yet another modular split ergonomic keyboard #17902

JohSchneider · 2022-08-03T23:12:59Z

created waaay back in 2017, based on/inspired by dactyl end ergodox like keyboards: curved ortholinear layout, with one MCU connected over TRRS to another half with an I2C-portexpander

a couple of small pcbs where designed around SMD chips -
to be usable as modular platform for putting together similar keyboards:
breakouts for ioexpanders, i2c buffer chips, ...

see the hackaday.io project page for futher build-instructions (to be updated...)

at the time the MCU of choice is/was a A-Star 32U4 Micro chosen for its diminutive size - but now that there are similar boards with an RP2040 out in the wild - and the support for these is slowly coming to QMK... :-D

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/handwired/yamsek/yamsek.h

keyboards/handwired/yamsek/atmega32u4/rules.mk

JohSchneider · 2022-10-29T15:48:31Z

this PR was waiting on #18178 which was merged... but..
@drashna what's the background that lead to the revert PR #18709 ? :-S

drashna · 2022-10-31T02:58:40Z

Basically, re-initing everything isn't the proper way to handle this. There are a couple of boards using the mcp code that can be used as examples to better handle detection, etc.

JohSchneider · 2022-10-31T16:39:07Z

There are a couple of boards using the mcp code

sadly there are multiple versions... the ergodox-derived ones do their own i2c handling (and reset everything everytime?), and only very few actually seem to use drivers/gpio/mcp23018

as evident by who uses init_mcp23018 == ergodox family; vs. drivers/gpio/mcp23018::mcp23018_init

did you have any specific "good examples" in mind?

drashna · 2022-11-08T07:57:01Z

The ergodone uses /drivers/gpio/mcp23018.c for the I/O expander code, and has detection/error handling.

JohSchneider · 2022-12-10T08:47:18Z

Note: the [core] I2C_PAL_MODE addition has it's own PR: #19286

JohSchneider · 2022-12-10T08:50:21Z

ok, compared the MCP23018 handling to how it's done in the ergodone (thanks for the hint)
seems pretty similar: calling mcp23018_init only once during startup; and as soon as i2c-errors accumulate, do a "weak" reinitialization by calling mcp23018_set_config

what else would be missing for this PR to be merged? (-:

keyboards/handwired/yamsek/rules.mk

keyboards/handwired/yamsek/yamsek.h

keyboards/handwired/yamsek/keymaps/default/keymap.c

keyboards/handwired/yamsek/atmega32u4/config.h

keyboards/handwired/yamsek/atmega32u4/rules.mk

keyboards/handwired/yamsek/config.h

keyboards/handwired/yamsek/readme.md

keyboards/handwired/yamsek/keymaps/default/readme.md

keyboards/handwired/yamsek/rp2040/rules.mk

JohSchneider · 2023-02-11T16:00:23Z

thanks for the info.json related hints : )
see last commit - comme ca?

keyboards/handwired/yamsek/config.h

keyboards/handwired/yamsek/rp2040/config.h

keyboards/handwired/yamsek/rules.mk

keyboards/handwired/yamsek/yamsek.c

platforms/chibios/chibios_config.h

JohSchneider · 2023-11-14T14:23:21Z

rebase onto develop

Q: is there anything i can or need to do to help this PR get merged? :-)

github-actions · 2023-12-31T01:50:11Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

sans 'VIAL' and the piromoni trackball... also only the polulu-a-star/atmega32u4 - rp2040 to follow Signed-off-by: Johannes Schneider <[email protected]>

aligning the LAYOUT macro with how the keys are layed out physically

with upstream defaults in mind, some can be dropped Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Drashna Jaelre <[email protected]>

fixing includes, removing redundant defines, etc Co-authored-by: Drashna Jaelre <[email protected]>

Signed-off-by: Johannes Schneider <[email protected]>

Co-authored-by: Sergey Vlasov <[email protected]> Signed-off-by: Johannes Schneider <[email protected]>

drop old-style keymap definition in favor of info.json entry Signed-off-by: Johannes Schneider <[email protected]>

'Layout "LAYOUT" is offset on Y axis by 1'

fix it to match the keymap Co-authored-by: Sergey Vlasov <[email protected]>

JohSchneider · 2023-12-31T06:58:23Z

no changes, just a rebase onto origin/master

github-actions · 2024-02-16T01:47:38Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2024-03-17T01:48:35Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

github-actions bot added keyboard keymap labels Aug 3, 2022

JohSchneider force-pushed the yamsek_2022 branch 2 times, most recently from 1b4d5de to bd610c6 Compare August 4, 2022 12:50

drashna reviewed Aug 6, 2022

View reviewed changes

keyboards/handwired/yamsek/yamsek.h Outdated Show resolved Hide resolved

precondition reviewed Aug 11, 2022

View reviewed changes

keyboards/handwired/yamsek/atmega32u4/rules.mk Outdated Show resolved Hide resolved

JohSchneider force-pushed the yamsek_2022 branch from 5838e25 to d642cb6 Compare August 27, 2022 12:49

JohSchneider marked this pull request as ready for review October 29, 2022 15:46

JohSchneider requested a review from drashna October 29, 2022 15:46

JohSchneider force-pushed the yamsek_2022 branch 3 times, most recently from 067e800 to 8278595 Compare December 10, 2022 07:59

github-actions bot added the core label Dec 10, 2022

JohSchneider force-pushed the yamsek_2022 branch from 8278595 to 448203b Compare December 10, 2022 08:12

KarlK90 mentioned this pull request Dec 11, 2022

[core] allow I2C_[SDA|SCL]_PAL_MODE to be (p)redefined #19286

Closed

14 tasks

drashna requested changes Jan 1, 2023

View reviewed changes

waffle87 requested changes Jan 14, 2023

View reviewed changes

drashna added the awaiting_pr Relies on another PR to be merged first label Jan 15, 2023

JohSchneider requested a review from waffle87 February 11, 2023 16:00

JohSchneider force-pushed the yamsek_2022 branch 2 times, most recently from a9e293d to 74137d8 Compare February 11, 2023 17:31

drashna requested changes Feb 17, 2023

View reviewed changes

JohSchneider removed the request for review from waffle87 February 20, 2023 18:01

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 15, 2023

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 31, 2023

JohSchneider and others added 19 commits December 31, 2023 07:57

YaMseK: current working state

2c530be

sans 'VIAL' and the piromoni trackball... also only the polulu-a-star/atmega32u4 - rp2040 to follow Signed-off-by: Johannes Schneider <[email protected]>

YaMseK: fix keyboard layout

6858cb2

aligning the LAYOUT macro with how the keys are layed out physically

YaMseK: cleanup

683fd6e

YaMseK: add rp2040 support

0b29136

YaMseK: minor cleanup

78e385e

YaMseK: build fixes

31537bb

update feature switches

bd8da89

with upstream defaults in mind, some can be dropped Co-authored-by: Drashna Jaelre <[email protected]>

remove unnecessary if-defed include

0231015

Co-authored-by: Drashna Jaelre <[email protected]>

YaMseK: realign keymap.c with yamsek.h

b53e20d

yamsek: config cleanup

31bae58

yamsek: convert to info.json

5f77f33

Apply suggestions from code review

ae2d759

fixing includes, removing redundant defines, etc Co-authored-by: Drashna Jaelre <[email protected]>

yamsek: fix compile errors after rebase onto develop

f1744c0

Signed-off-by: Johannes Schneider <[email protected]>

Apply suggestions from code review

46bb191

Co-authored-by: Sergey Vlasov <[email protected]> Signed-off-by: Johannes Schneider <[email protected]>

update keymap in info.json

396773f

drop old-style keymap definition in favor of info.json entry Signed-off-by: Johannes Schneider <[email protected]>

yamsek: fix key positions in info.json

240573d

yamsek: fix lint warning

f524aea

'Layout "LAYOUT" is offset on Y axis by 1'

Update keyboards/handwired/yamsek/info.json

5f68a86

fix it to match the keymap Co-authored-by: Sergey Vlasov <[email protected]>

fix minor LINT error in the rules.mk

84bd503

JohSchneider force-pushed the yamsek_2022 branch from 3f94cc4 to 84bd503 Compare December 31, 2023 06:57

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 1, 2024

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 16, 2024

github-actions bot closed this Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YaMseK: yet another modular split ergonomic keyboard #17902

YaMseK: yet another modular split ergonomic keyboard #17902

JohSchneider commented Aug 3, 2022

JohSchneider commented Oct 29, 2022

drashna commented Oct 31, 2022

JohSchneider commented Oct 31, 2022 •

edited

Loading

drashna commented Nov 8, 2022

JohSchneider commented Dec 10, 2022

JohSchneider commented Dec 10, 2022

JohSchneider commented Feb 11, 2023

JohSchneider commented Nov 14, 2023

github-actions bot commented Dec 31, 2023

JohSchneider commented Dec 31, 2023

github-actions bot commented Feb 16, 2024

github-actions bot commented Mar 17, 2024

YaMseK: yet another modular split ergonomic keyboard #17902

YaMseK: yet another modular split ergonomic keyboard #17902

Conversation

JohSchneider commented Aug 3, 2022

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

JohSchneider commented Oct 29, 2022

drashna commented Oct 31, 2022

JohSchneider commented Oct 31, 2022 • edited Loading

drashna commented Nov 8, 2022

JohSchneider commented Dec 10, 2022

JohSchneider commented Dec 10, 2022

JohSchneider commented Feb 11, 2023

JohSchneider commented Nov 14, 2023

github-actions bot commented Dec 31, 2023

JohSchneider commented Dec 31, 2023

github-actions bot commented Feb 16, 2024

github-actions bot commented Mar 17, 2024

JohSchneider commented Oct 31, 2022 •

edited

Loading