Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Develop] Adafruit Macropad: Add VIA keymap, fix default km #17735

Merged
merged 1 commit into from
Jul 21, 2022
Merged

[Develop] Adafruit Macropad: Add VIA keymap, fix default km #17735

merged 1 commit into from
Jul 21, 2022

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Jul 21, 2022

Description

Enable Encoder map on default keymap and fix incorrect keycodes in the encoder map.
Add VIA keymap (with Encoder Map support)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Jul 21, 2022
@Jpe230 Jpe230 mentioned this pull request Jul 21, 2022
Closed
6 tasks
@zvecr zvecr requested a review from a team July 21, 2022 12:40
@zvecr zvecr merged commit 5c90732 into qmk:develop Jul 21, 2022
@Jpe230
Copy link
Contributor Author

Jpe230 commented Jul 21, 2022

Thanks for the merge!

@Jpe230 Jpe230 deleted the adafruit_macropad_via branch July 21, 2022 13:55
@Jpe230 Jpe230 mentioned this pull request Dec 27, 2022
Merged
6 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Jpe230 @nolanseaton
Adafruit Macropad: Add VIA keymap, fix default km (qmk#17735)
5e321ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jpe230 @fauxpark @zvecr