-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bonsai C4 converter #17711
Add Bonsai C4 converter #17711
Conversation
Could you also update the docs at https://github.com/qmk/qmk_firmware/blob/develop/docs/feature_converters.md.
Maybe, not sure I will have time before the end of the current develop cycle to improve the situation. Somewhat depends the level of "Out the box" configuration its providing. |
Documentation has been updated. Because the generic board doesn't have peripherals enabled, instead of including a section listing the enabled and disabled defaults, I've added a reference to some template code that can be used to enable peripherals as needed. It seems like a reasonable way to provide some form of implementation guidance (at least until tailoring of board files becomes possible), but if that approach is not preferred even as a temporary solution, it can be removed or organized in a completely different way. I just thought it might be helpful to provide some sort of relevant starting point (example code) in the interim. In the case of Bonsai C4, the out-of-the-box configuration I'd prefer to include as part of the converter experience is:
...which is actually most of the items included in the example code, aside from basic PWM backlighting (which probably should be excluded from the default configuration as it is less-used). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs conflicts fixed, too.
Sorry, got conflicts again. Will merge asap once they are resolved. |
Adds converter for:
promicro -> bonsai c4
At the moment this PR only performs basic pin conversion. Despite peripheral support being needed to access on-board EEPROM and flash memory chips on Bonsai C4, peripheral support is currently not included because this converter leverages the existing GENERIC_STM32_F411XE board definition, and boards inheriting boards is not yet available.
If it is preferable to use dedicated Bonsai C4 board/config files (which include peripheral support) in the meantime, I have that ready as well and can update the PR accordingly.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist