Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Introduce pointing device specific debug messages #17663

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 13, 2022

Description

Spun out of #17613

...as debug messages from the pointing device drivers can be come quite verbose. These can be enabled with POINTING_DEVICE_DEBUG define on a keyboard level.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 mentioned this pull request Jul 13, 2022
14 tasks
@KarlK90 KarlK90 force-pushed the feature/pointing-device-debug-messages branch from ecc820e to 7e3294d Compare July 14, 2022 09:52
@KarlK90 KarlK90 marked this pull request as ready for review July 14, 2022 09:53
@KarlK90 KarlK90 requested a review from a team July 14, 2022 09:53
quantum/pointing_device_internal.h Outdated Show resolved Hide resolved
@KarlK90 KarlK90 requested a review from fauxpark July 15, 2022 13:19
@tzarc
Copy link
Member

tzarc commented Aug 13, 2022

Should be good if we can get the conflicts sorted.

@drashna
Copy link
Member

drashna commented Aug 13, 2022

It also errors out on the pmw33xx drivers. Needs the internals include somewhere.

@tzarc
Copy link
Member

tzarc commented Aug 14, 2022

Ideally we'd get this in this cycle, but @KarlK90 may not be near a workstation for a bit. We'll see, deferring for now.

@KarlK90 KarlK90 force-pushed the feature/pointing-device-debug-messages branch 2 times, most recently from 76fcdf9 to 3b6731a Compare August 14, 2022 17:38
As these can be come quite verbose, these can be enabled with
POINTING_DEVICE_DEBUG define on a keyboard level.
@KarlK90 KarlK90 force-pushed the feature/pointing-device-debug-messages branch from 3b6731a to 88cfd98 Compare August 14, 2022 17:49
@KarlK90 KarlK90 requested review from drashna and tzarc August 14, 2022 17:56
@KarlK90
Copy link
Member Author

KarlK90 commented Aug 14, 2022

@drashna @tzarc should be good to go now

@drashna drashna requested a review from a team August 21, 2022 19:31
@KarlK90 KarlK90 merged commit e99ec28 into qmk:develop Aug 29, 2022
@KarlK90 KarlK90 deleted the feature/pointing-device-debug-messages branch August 29, 2022 17:16
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants