Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgbkb/zen - Resolve CONVERT_TO_PROTON_C warnings #17619

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 11, 2022

Description

A little more involved than others, due to the custom logic:

  • bitbang split should work
    • user still has the choice to use a single hand
  • rgb remains disabled till someone adds driver defaults
  • minor tidy up of redundant files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 11, 2022 00:55
@drashna drashna requested a review from a team July 11, 2022 11:30
@zvecr zvecr merged commit a6ea760 into qmk:master Aug 7, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants