Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rgbkb/sol/rev2 build issues #17601

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 8, 2022

Description

  • Ignore led config that contains preprocessor
  • Generate ENCODER_RESOLUTION when all values are same value
    • avoids generating ENCODER_RESOLUTIONS which might not match len(ENCODERS_PAD_A)
      • this is due to preprocessor use around encoders - last value wins

#17460 will continue efforts to gracefully handle preprocessor in config.h files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jul 8, 2022
@zvecr zvecr added the bug label Jul 8, 2022
@zvecr zvecr marked this pull request as ready for review July 8, 2022 21:19
@zvecr zvecr requested a review from a team July 8, 2022 21:22
@zvecr zvecr merged commit 81d317a into qmk:develop Jul 8, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants