Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] printf update aftermath #17584

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[Fix] printf update aftermath #17584

merged 1 commit into from
Jul 7, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 7, 2022 •
edited
Loading

Description

  • Add missing '(' to print_bin_reverse32 declaration
  • Fix insufficient character buffers on satisfaction75
  • Remove \0 character in format string and use corrected offset math
    instead on rocketboard 16
  • Replace snprintf_ with snprintf for djinn
  • Explicitly ignore format checks for tracktyl manuform that uses %b
    specifier
  • Print properly escaped version string in command.c, as PRODUCT or
    other defines can contain constructs like 'Vendor keyboard 66%' which
    will be interpreted as a format specifier

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 requested a review from tzarc July 7, 2022 11:51
@github-actions github-actions bot added core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2022
@KarlK90 KarlK90 requested a review from a team July 7, 2022 11:52
@KarlK90
[Fix] Patches after printf library update
bcf3c72 
* Add missing '(' to print_bin_reverse32 declaration
* Fix insufficient character buffers on satisfaction75
* Remove \0 character in format string and use corrected offset math
  instead on rocketboard 16
* Replace snprintf_ with snprintf for djinn
* Explicitly ignore format checks for tracktyl manuform that uses %b
  specifier
* Print properly escaped version string in command.c, as PRODUCT or
  other defines can contain constructs like 'Vendor keyboard 66%' which
  will be interpreted as a format specifier
@KarlK90 KarlK90 force-pushed the fix/printf-aftermath branch from 1fcdec9 to bcf3c72 Compare July 7, 2022 11:56
@KarlK90 KarlK90 merged commit 643f636 into qmk:develop Jul 7, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
[Fix] Patches after printf library update (qmk#17584)
623a7c5 
* Add missing '(' to print_bin_reverse32 declaration
* Fix insufficient character buffers on satisfaction75
* Remove \0 character in format string and use corrected offset math
  instead on rocketboard 16
* Replace snprintf_ with snprintf for djinn
* Explicitly ignore format checks for tracktyl manuform that uses %b
  specifier
* Print properly escaped version string in command.c, as PRODUCT or
  other defines can contain constructs like 'Vendor keyboard 66%' which
  will be interpreted as a format specifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarlK90 @tzarc @zvecr