Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Foundation to QMK #17573

Merged
merged 10 commits into from
Aug 13, 2022
Merged

Conversation

mechlovin
Copy link
Contributor

@mechlovin mechlovin commented Jul 6, 2022

Description

Add Foundation PCB to QMK.
F row less layout, APM32F103, rotary encoder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 6, 2022
keyboards/mechlovin/foundation/config.h Outdated Show resolved Hide resolved
keyboards/mechlovin/foundation/foundation.c Outdated Show resolved Hide resolved
keyboards/mechlovin/foundation/foundation.h Outdated Show resolved Hide resolved
keyboards/mechlovin/foundation/foundation.h Outdated Show resolved Hide resolved
keyboards/mechlovin/foundation/foundation.h Outdated Show resolved Hide resolved
keyboards/mechlovin/foundation/foundation.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Jul 11, 2022

Lint:

☒ mechlovin/foundation: Number of keys for LAYOUT_tkl_nofrow_ansi does not match! info.json specifies 78 keys, C macro specifies 76
☒ mechlovin/foundation: Number of keys for LAYOUT_tkl_nofrow_iso does not match! info.json specifies 79 keys, C macro specifies 77

@mechlovin mechlovin requested a review from drashna July 12, 2022 02:47
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change this to encoder map before it's merged @mechlovin

@mechlovin
Copy link
Contributor Author

Yes, please wait me for few hour.

@mechlovin
Copy link
Contributor Author

Encoder map has been enabled.
Thanks

@keyboard-magpie keyboard-magpie merged commit 1eecdb5 into qmk:master Aug 13, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
* add mechlovin foundation keyboard

Co-authored-by: Drashna Jaelre <[email protected]>
@mechlovin mechlovin deleted the foundation branch November 9, 2022 11:09
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* add mechlovin foundation keyboard

Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants