Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap F4x1 default board files away from blackpill #17522

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 1, 2022

Description

Going forward this aligns the defaults with other STM32 variants. Blackpill users should take advantage of the DD info.json config:

{
  "development_board": "blackpill_f401"
}

or

{
  "development_board": "blackpill_f411"
}

Which will correctly set up the mcu / bootlaoder / board files.

# Find keyboards to migrate
rg -l "MCU = STM32F4.1" keyboards/ | xargs grep -L "^BOARD"

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Jul 1, 2022
@zvecr zvecr mentioned this pull request Aug 14, 2022
14 tasks
@zvecr zvecr marked this pull request as ready for review August 14, 2022 22:28
@zvecr zvecr requested a review from a team August 14, 2022 22:30
@zvecr zvecr force-pushed the feature/f4_default_board branch from 28d34fa to 963b985 Compare August 15, 2022 00:04
@zvecr zvecr mentioned this pull request Aug 15, 2022
14 tasks
@zvecr zvecr merged commit 0fcebdc into qmk:develop Aug 18, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants