Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs regarding USB_SUSPEND_WAKEUP_DELAY #17501

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

ThreeFx
Copy link
Contributor

@ThreeFx ThreeFx commented Jun 29, 2022

This matches the value found in the documentation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ThreeFx
Copy link
Contributor Author

ThreeFx commented Jun 29, 2022

Things left to consider: Should we remove all keyboard configurations that already set it to 200? Or should we leave it up to the respective maintainers?

@github-actions github-actions bot added the core label Jun 29, 2022
@zvecr zvecr changed the base branch from master to develop June 29, 2022 17:21
@drashna
Copy link
Member

drashna commented Jul 1, 2022

If anything, the documentation should be changed here, not the default.

#12081

Specifically, when this was introduced, the default was set to 200ms by default and it caused a lot of issues. So it was revert to 0ms (disabled). However, the document didn't get updated to reflect the change.

@ThreeFx ThreeFx force-pushed the fix-usb-suspend-wakeup-delay branch from 999b4c4 to 83fd6d9 Compare July 4, 2022 09:10
@ThreeFx
Copy link
Contributor Author

ThreeFx commented Jul 4, 2022

Makes sense, in this case I've fixed the documentation to reflect that change, with a little note added that tweaking USB_SUSPEND_WAKEUP_DELAY might be a good idea when seeing resume issues. Unfortunately, I don't speak Japanese, so I only added it to the English version.

@ThreeFx ThreeFx changed the title Set USB_SUSPEND_WAKEUP_DELAY to 200ms by default Fix docs regarding USB_SUSPEND_WAKEUP_DELAY Jul 4, 2022
@ThreeFx ThreeFx force-pushed the fix-usb-suspend-wakeup-delay branch from 83fd6d9 to 73953f5 Compare July 4, 2022 09:13
docs/config_options.md Outdated Show resolved Hide resolved
@ThreeFx ThreeFx force-pushed the fix-usb-suspend-wakeup-delay branch from 73953f5 to c02ae09 Compare July 13, 2022 12:01
@drashna drashna requested a review from a team July 16, 2022 18:35
@zvecr zvecr merged commit 1db5272 into qmk:develop Jul 20, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants