Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine!40 PCB Support #17426

Merged
merged 23 commits into from
Jul 11, 2022
Merged

Fine!40 PCB Support #17426

merged 23 commits into from
Jul 11, 2022

Conversation

Aidan-OS
Copy link
Contributor

Added code for the Fine!40 PCB which is used in the Mochi40 currently in group buy.

Description

The Fine!40 is an Elite-C based PCB with a rotary encoder and an OLED display. The code provided additionally incudes VIA support.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None, except for the absolute mess that my last PR was because I apparently started with a very outdated base (among other things).

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 19, 2022
@Aidan-OS
Copy link
Contributor Author

Okay, there is a folder here I was sure I removed. I'll fix that.

@Aidan-OS
Delete keyboards/fine40 directory
4213c39 
I'm not entirely sure how this got here again.
zvecr
zvecr requested changes Jun 19, 2022
View reviewed changes
keyboards/aidansmithdotdev/fine40/fine40.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/fine40.h Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/rules.mk Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/info.json Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Aidan-OS and others added 8 commits June 19, 2022 18:55
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c
ff100da 
Simplified license declaration

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c
9a78a6f 
Simplified license declaration

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/info.json
1cb4b04 
Move optional addons to info.json

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/rules.mk
8de7a32 
Move optional addons to info.json

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS
Delete fine40.h
41ea419 
Move optional addons to info.json
@Aidan-OS
Delete fine40.c
6e56010 
Move optional addons to info.json
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/keymaps/default/keymap.c
69698a3 
Removing unneeded keymap bloat.

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS @zvecr
Update keyboards/aidansmithdotdev/fine40/keymaps/via/keymap.c
8ee54a5 
Removing unneeded keymap bloat.

Co-authored-by: Joel Challis <[email protected]>
@Aidan-OS
Copy link
Contributor Author

I think everything should be fixed now? It says that there is one change remaining but I don't see it.

@drashna
Copy link
Member

drashna commented Jun 19, 2022

Please do not close and re-open PRs. Updating the branch on your repo will automatically update the PR. Even if the old PR is master, that's fine. Do it "right", the next time.
#17328

@Aidan-OS
Copy link
Contributor Author

@drashna I'm sorry for all the mistakes. I assumed that I should close it because of the master situation.

@drashna
Copy link
Member

drashna commented Jun 19, 2022

No worries. And git/github is always a learning experience, for sure!

@Aidan-OS
Copy link
Contributor Author

Not sure what changes GitHub thinks are left outstanding as I think I have gotten everything now.

@Aidan-OS @drashna
Apply suggestions from code review
67ee00a 
Adding safety check

Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team June 21, 2022 01:57
fauxpark
fauxpark requested changes Jun 21, 2022
View reviewed changes
keyboards/aidansmithdotdev/fine40/readme.md Outdated Show resolved Hide resolved
keyboards/aidansmithdotdev/fine40/info.json Outdated Show resolved Hide resolved
@Aidan-OS
Copy link
Contributor Author

Just wanted to check, is there anything that I have missed?

@Aidan-OS
Copy link
Contributor Author

Aidan-OS commented Jul 5, 2022

Is that everything?

@Aidan-OS
Copy link
Contributor Author

Aidan-OS commented Jul 9, 2022

Is there anything else that is needed?

@drashna drashna merged commit 7a73f9a into qmk:develop Jul 11, 2022
@Aidan-OS
Copy link
Contributor Author

Aidan-OS commented Aug 2, 2022

I don't know how I missed this earlier, but it appears that the Rotary Encoder is no longer functioning with the new setup. I've tried debugging but have no clue what is causing the problem, though I haven't worked with the new method of declaring things in info.json.

@Aidan-OS Aidan-OS mentioned this pull request Nov 4, 2022
Merged
6 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@Aidan-OS @zvecr
@drashna @fauxpark @nolanseaton
[Keyboard] Add Fine!40 PCB Support (qmk#17426)
d45efba 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aidan-OS @drashna @fauxpark @zvecr