Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SPLIT_HAND_PIN setup to split_pre_init #17271

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Move SPLIT_HAND_PIN setup to split_pre_init #17271

merged 3 commits into from
Jun 6, 2022

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented May 31, 2022 •
edited
Loading

Description

Rather than setting the pin to input each check, it's done once during setup. This is to allow for a delay and ensure a correct reading is taken.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 31, 2022
@daskygit
Copy link
Member Author

daskygit commented May 31, 2022 •
edited
Loading

The old way would allow the pin to be shared, I've not checked the repo for this case yet.

I've opened as draft so it can be easily tested further by others.

@drashna drashna requested a review from a team May 31, 2022 21:25
@daskygit
Copy link
Member Author

daskygit commented Jun 5, 2022

The old way would allow the pin to be shared, I've not checked the repo for this case yet.

I've opened as draft so it can be easily tested further by others.

So after doing a check it seems doppelganger reused the SPLIT_HAND_PIN in the matrix, I've added a is_keyboard_left function for that board to ensure the same behaviour as before.

@daskygit daskygit marked this pull request as ready for review June 5, 2022 22:28
@daskygit @zvecr
Add comment for future
f5a8f18 
Co-authored-by: Joel Challis <[email protected]>
@zvecr zvecr merged commit 85b3b98 into qmk:develop Jun 6, 2022
@daskygit daskygit deleted the fix/split_hand_pin branch June 6, 2022 00:43
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@daskygit @zvecr @zykrah
Move SPLIT_HAND_PIN setup to split_pre_init (qmk#17271)
ca8b9a3 
* Move SPLIT_HAND_PIN setup to split_pre_init

* doppelganger should use old behaviour

* Add comment for future

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @zvecr