[Keyboard] IDOBAO ID80v1 folder rename #17265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 29, 2022 18:36
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
May 31, 2022
Co-authored-by: Drashna Jaelre <[email protected]>
drashna
approved these changes
Jun 2, 2022
fauxpark
requested changes
Jun 3, 2022
Co-authored-by: Ryan <[email protected]>
|
Have these been checked to make sure they still compile? |
|
absolument
|
drashna
approved these changes
Jun 11, 2022
tzarc
approved these changes
Aug 13, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IDOBAO support has received numerous support calls with users confused with the "v1" name used in the folder structure introduced in #15992.
The code in the
v1folder is a folder shift from the base of theid80folder and actually pertains to the "v2" boards. Both "v1" (with no per-key under-light, or rather; self-solder per-key) and "v2" (with manufactured white per-key leds) are compatible with that code base - however users seeking code for their "v2" boards are using the "v3" codebase, and this is not compatible as it uses RGB LED's and the RGB Matrix codebase.This PR seeks to rename the "v1" folder to "v2" (to eliminate confusion), and then add a
readme.mdandrules.mkfile to the "v1" (ensuring backward compatibility).Types of Changes
Issues Fixed or Closed by This PR
Checklist