Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] IDOBAO ID87v2 code rewrite and include factory keymap #17232

Merged
merged 6 commits into from
Jul 2, 2022

Conversation

silvinor
Copy link
Contributor

@silvinor silvinor commented May 29, 2022

Description

Re-do of IDOBAO keyboards - ID87v2 TKL

This PR is a rewrite of the ID87v2 keyboard range and includes:

  • Data driven configuration from the info.json file.
  • .. including changing the USB Device ID from 0x0087 to 0x0287, as the latter causes issues with ID87v1 users leveraging VIA, as the older board had white underkey and the new V2 has RGB underkey. Using the same PID would cause one of these to be excluded from the VIA JSON stack and/or VIA to crash when selecting the LIGHTING tab.
  • Clean-up of RGB Matrix animations
  • id87.c file:
    • Rewrite of Matrix g_led_config var as former code had incorrect coordinates for LED positions
    • Text graphical map of LED addresses
  • Keymaps:
    • Removal of VIA_QMK_RGBLIGHT_ENABLE (not needed since QMK 0.17)
    • Text graphical map of keys in default and via keymaps
    • Addition of idobao keymap, that represents the source code of the factory installed firmware

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 29, 2022
@drashna drashna requested a review from a team May 31, 2022 07:49
@tzarc tzarc merged commit 7a5f76d into qmk:develop Jul 2, 2022
@silvinor silvinor deleted the vr-id87-v2-dev-touch branch July 3, 2022 01:51
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants