[Keyboard] IDOBAO ID87v2 code rewrite and include factory keymap #17232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-do of IDOBAO keyboards - ID87v2 TKL
This PR is a rewrite of the ID87v2 keyboard range and includes:
info.json
file.0x0087
to0x0287
, as the latter causes issues with ID87v1 users leveraging VIA, as the older board had white underkey and the new V2 has RGB underkey. Using the same PID would cause one of these to be excluded from the VIA JSON stack and/or VIA to crash when selecting the LIGHTING tab.id87.c
file:g_led_config var
as former code had incorrect coordinates for LED positionsVIA_QMK_RGBLIGHT_ENABLE
(not needed since QMK 0.17)default
andvia
keymapsidobao
keymap, that represents the source code of the factory installed firmwareTypes of Changes
Issues Fixed or Closed by This PR
Checklist