Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Add solid reactive gradient mode #17228

Merged
merged 1 commit into from
Jul 14, 2022
Merged

[Code] Add solid reactive gradient mode #17228

merged 1 commit into from
Jul 14, 2022

Conversation

filterpaper
Copy link
Contributor

Description

Add gradient color mode to all 5 RGB matrix solid reactive effect. With this mode enabled, the reactive color hue will slowly change over time.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 29, 2022 21:24
KarlK90
KarlK90 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@daskygit daskygit merged commit 300dab7 into qmk:develop Jul 14, 2022
@filterpaper filterpaper deleted the rgb-matrix-gradient-mode branch July 14, 2022 11:38
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@filterpaper @nolanseaton
[Code] Add solid reactive gradient mode (qmk#17228)
9a0091b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @KarlK90 @daskygit