Make bootloader_jump for dualbank STM32 respect STM32_BOOTLOADER_DUAL_BANK_DELAY #17178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preisi
force-pushed
the
stm32_bootloader_dualbank_delay
branch
from
422ec3a to
0a2bb08
Compare
drashna
approved these changes
May 21, 2022
fauxpark
approved these changes
May 21, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the code for STM32s with dualbank flash contains a define named STM32_BOOTLOADER_DUAL_BANK_DELAY which is never used. Instead, the actual delay is hardcoded to 100ms inside the respective bootloader_jump-function.
This commit changes the default value of said define to the aforementioned 100ms to keep the current behaviour. Additionally, the hardcoded 100ms are replaced with the previously unused define to actually allow modifying the charging delay before resetting the MCU.
Description
Types of Changes
Checklist