Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to allow Sesame to work without atomic interactions #17034

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

ollien
Copy link

@ollien ollien commented May 8, 2022

Description

This is a small workaround for #11389. While I don't love it (as this ultimately just works around the root cause), the original PR that caused this bug seems to be a fix for RGB (#10491), which this board does not have. It also seems that some other keyboards (namely massdrop/alt and massdrop/ctrl) seem to have done similar, citing "matrix delay", which I can only assume is this same issue.

cc: @kb-elmo

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Add workaround to allow Sesame to work without matrix delay Add workaround to allow Sesame to work without atomic interactions May 8, 2022
@drashna drashna requested a review from a team May 11, 2022 11:32
Copy link
Contributor

@kb-elmo kb-elmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@fauxpark
Copy link
Member

fauxpark commented May 11, 2022

Since this issue likely affects most other V-USB boards, it might be better to generalise this a little more. I'm actually thinking even my Plaid-Pad may be affected, as I recall having to tweak the delays on my macros around this time...

@tzarc tzarc merged commit 69f0fc5 into qmk:master Jul 2, 2022
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants