Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gentleman 65 SE Solderd PCB support #16992

Merged
merged 8 commits into from
Aug 14, 2022
Merged

Add Gentleman 65 SE Solderd PCB support #16992

merged 8 commits into from
Aug 14, 2022

Conversation

JJ48
Copy link

@JJ48 JJ48 commented May 2, 2022

Description

added support for Gentleman 65 SE Solderd PCB, made small bug fixes to gent 65 firmware, and added gentleman65 and gentleman65_se_s to the jkeys_design folder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 2, 2022
@JJ48 JJ48 requested a review from drashna May 4, 2022 02:46
@drashna drashna requested a review from a team May 4, 2022 15:11
@tzarc tzarc changed the base branch from master to develop July 2, 2022 11:39
@tzarc
Copy link
Member

tzarc commented Jul 2, 2022

Retargeted to develop as it involves a keyboard relocation.
Please update data/mappings/keyboard_aliases.json with the new location.

@drashna
Copy link
Member

drashna commented Jul 2, 2022

This has some merge conflicts that need resolution before it can be merged.

@keyboard-magpie
Copy link
Contributor

@JJ48 don't know if you saw Drashna's above.

@zvecr zvecr merged commit 4eda139 into qmk:develop Aug 14, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@JJ48 @nolanseaton
Add Gentleman 65 SE Solderd PCB support (qmk#16992)
63cc4b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JJ48 @tzarc @drashna @keyboard-magpie @fauxpark @zvecr