Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework qmk compile to bypass Makefile. Add new --filter option. #16872

Closed
wants to merge 1 commit into from
Closed

Rework qmk compile to bypass Makefile. Add new --filter option. #16872

wants to merge 1 commit into from

Conversation

SEAN-JOU
Copy link

@SEAN-JOU SEAN-JOU commented Apr 18, 2022 •
edited
Loading

Description

Types of Changes

  • [V ] Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • [V ] I have read the PR Checklist document and have made the appropriate changes.
  • [V ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Apr 18, 2022
@drashna drashna changed the base branch from master to develop April 18, 2022 05:29
@drashna
Copy link
Member

drashna commented Apr 18, 2022

As this is a major code change, and structural change, have you discussed this with anyone?

@zvecr
Copy link
Member

zvecr commented Apr 18, 2022

Its also just the content of #13357, which opening a PR that still has merge conflicts no value.

@zvecr zvecr closed this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SEAN-JOU @drashna @zvecr @skullydazed