Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joystick feature updates #16732

Merged
merged 3 commits into from
Mar 26, 2022
Merged

Joystick feature updates #16732

merged 3 commits into from
Mar 26, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 26, 2022 •
edited
Loading

Description

  • Refactored process_joystick(); extracted register_joystick_button()/unregister_joystick_button()
  • Added joystick.h include in quantum.h so that it's implicitly visible at keyboard/keymap-level

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 26, 2022 08:08
@drashna drashna requested a review from a team March 26, 2022 14:55
@zvecr zvecr merged commit c05e8af into qmk:develop Mar 26, 2022
@fauxpark fauxpark deleted the joystick-feature-updates branch March 26, 2022 19:22
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@fauxpark @zykrah
Joystick feature updates (qmk#16732)
2d7b3e6 
* Joystick feature updates

* Move new functions to joystick.h

* Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr