Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frameworking for development board presets #16637

Merged
merged 2 commits into from
Apr 3, 2022
Merged

Add frameworking for development board presets #16637

merged 2 commits into from
Apr 3, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 13, 2022 •
edited
Loading

Description

Cherry picked whats ready to go from #16598.

This PR aims to...

  • Provide context for later conversion logic to key against
  • Reduce boilerplate
  • Later enhance new-keyboard?

Name is still up for grabs as "development_board" still feels a little wordy. (Currently chosen as it seems to be common enough when browsing various documention/stores). Alternative names?

  • "preset"
  • "carrier_board"
  • "dev_board"
  • "controller"
  • "module" - maybe too close to RIOT terminology

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Mar 13, 2022
@zvecr zvecr requested a review from a team March 13, 2022 20:06
@KarlK90
Copy link
Member

KarlK90 commented Mar 18, 2022

Development board is ubiquitous but I would prefer controller in QMK, preset is to generic in my opinion.

@Erovia
Copy link
Member

Erovia commented Mar 25, 2022

Development board is ubiquitous but I would prefer controller in QMK, preset is to generic in my opinion.

I'm torn between controller and development_board. For some reason I prefer the latter, but wouldn't mind either, tbh.

@zvecr zvecr requested review from a team and Erovia April 3, 2022 17:23
@zvecr zvecr force-pushed the feature/converters4 branch from 0a2afbb to 0dcc1b0 Compare April 3, 2022 17:29
tzarc
tzarc requested changes Apr 3, 2022
View reviewed changes
lib/python/qmk/info.py Outdated Show resolved Hide resolved
@zvecr zvecr merged commit c0ac3f7 into qmk:develop Apr 3, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@zvecr @tzarc @zykrah
Add frameworking for development board presets (qmk#16637)
e7e2f5a 
* Add frameworking for development board presets

* Update lib/python/qmk/info.py

Co-authored-by: Nick Brassel <[email protected]>

Co-authored-by: Nick Brassel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlK90 KarlK90 KarlK90 approved these changes

@tzarc tzarc tzarc approved these changes

@Erovia Erovia Awaiting requested review from Erovia

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @KarlK90 @Erovia @tzarc