Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add paw3204 mouse sensor #16594

Closed
wants to merge 18 commits into from
Closed

add paw3204 mouse sensor #16594

wants to merge 18 commits into from

Conversation

gompa
Copy link

@gompa gompa commented Mar 9, 2022

add paw 3204 mouse sensors driver

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • [x ] Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [x ] I have read the PR Checklist document and have made the appropriate changes.
  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop March 9, 2022 13:24
drashna
drashna requested changes Mar 9, 2022
View reviewed changes
quantum/pointing_device.h Outdated Show resolved Hide resolved
quantum/pointing_device_drivers.c Outdated Show resolved Hide resolved
drivers/sensors/paw3204.c Show resolved Hide resolved
drashna
drashna reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you add a set/get cpi function that sets the resolution

@gompa
Copy link
Author

gompa commented Mar 9, 2022

Also, could you add a set/get cpi function that sets the resolution

something like this ?

drashna
drashna requested changes Mar 9, 2022
View reviewed changes
drivers/sensors/paw3204.c Outdated Show resolved Hide resolved
drivers/sensors/paw3204.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 9, 2022 18:48
@drashna drashna requested review from daskygit and a team March 9, 2022 20:38
fauxpark
fauxpark requested changes Mar 10, 2022
View reviewed changes
docs/feature_pointing_device.md Show resolved Hide resolved
docs/feature_pointing_device.md Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 14, 2022 01:58
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 24, 2022
@drashna drashna closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit left review comments

@fauxpark fauxpark fauxpark requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gompa @drashna @fauxpark @daskygit