Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone chibios and ugfx if it's not already checked out. #1651

Merged
merged 2 commits into from
Sep 6, 2017

Conversation

skullydazed
Copy link
Member

This clones chibios and ugfx if the directories don't already exist, and adds make targets for anyone that wants to make lib/<dep> themselves.

This will clone even for avr users, but likely most avr users blindly cloned anyway due to the scary looking warning at the top of their make output. If they wish to avoid the automatic clone they can use SKIP_GIT, or they can mkdir lib/chibios lib/chibios-contrib lib/ugfx.

It would be better if these only cloned for chibios keyboards but due to how make works I can't find a place to hook into before the chibios make infrastructure is imported without running into *** commands commence before first target. Stop. errors.

@skullydazed skullydazed requested a review from fredizzimo August 28, 2017 16:49
@skullydazed skullydazed merged commit 2b3803e into master Sep 6, 2017
@domoaligato
Copy link

make clean
QMK Firmware vplanck-4.1
error: pathspec 'lib/chibios' did not match any file(s) known to git.
../../Makefile:513: recipe for target 'clean' failed
make: *** [clean] Error 1

@skullydazed skullydazed deleted the chibios_make branch September 8, 2017 04:24
@jackhumbert
Copy link
Member

@domoaligato can you try making from the root folder?

@domoaligato
Copy link

I am doing make clean or make KEYMAP=poker in /keyboards/satan/

@jackhumbert
Copy link
Member

@domoaligato we're reworking the makefile structure so that you'll need to make from the root (qmk_firmware) folder - for more info on that, checkout #1659

@domoaligato
Copy link

thanks that works. I did a "make allkb-allsp-allkm" and some projects that have been updated to support worked. Could the wiki maybe be updated? it still says that it supports compiling inside the keyboard directory.

@jackhumbert
Copy link
Member

@domoaligato can you link where you saw that? I think we still need to update the docs for that PR.

@domoaligato
Copy link

https://docs.qmk.fm/getting_started_make_guide.html
look for this... and behaviour is supposed to be spelled behavior :)

make from within a keyboard directory, is the same as make keyboard-allsp-allkm, which compiles all subprojects and keymaps of the keyboard. NOTE that this behaviour has changed. Previously it compiled just the default keymap.

@domoaligato
Copy link

can I make clean all somehow?

@jackhumbert
Copy link
Member

;) Thanks!

You can just delete the .build folder in the root - this will delete everything except the .hex files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants