Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error for LED Matrix effect solid_reactive_wide. #16383

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix build error for LED Matrix effect solid_reactive_wide. #16383

merged 1 commit into from
Feb 17, 2022

Conversation

firetech
Copy link
Contributor

Description

An exclamation mark was mistakenly left behind in #15018, causing compilation to fail when ENABLE_LED_MATRIX_SOLID_REACTIVE_WIDE was not defined.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@firetech
Fix build error for LED Matrix effect solid_reactive_wide.
a79f8e7 
An exclamation mark was mistakenly left behind in qmk#15018, causing
compilation to fail when `ENABLE_LED_MATRIX_SOLID_REACTIVE_WIDE` was not
defined.
@github-actions github-actions bot added the core label Feb 16, 2022
@firetech
Copy link
Contributor Author

The compilation error (warning, really, but gcc was run with -Werror) I got was that SOLID_REACTIVE_WIDE_math was defined but not used.

@drashna drashna requested a review from a team February 17, 2022 16:39
@drashna drashna merged commit 7dd993f into qmk:master Feb 17, 2022
@firetech firetech deleted the fix_led_matrix_solid_reactive_wide_build branch May 8, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firetech @drashna @fauxpark