Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redox_w] add dvorak layout and white led support #16259

Merged
merged 5 commits into from
Feb 21, 2022

Conversation

66f94eae
Copy link

@66f94eae 66f94eae commented Feb 7, 2022

Description

add white led control,and remove useless led define,like "set_led_yellow" @mattdibi
add dvorak layout,and caps_lock,num_lock led Indicators

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/redox_w/keymaps/dvorak/keymap.c Outdated Show resolved Hide resolved
keyboards/redox_w/redox_w.h Show resolved Hide resolved
define layers enum

Co-authored-by: Drashna Jaelre <[email protected]>
@66f94eae 66f94eae requested a review from drashna February 9, 2022 01:27
keyboards/redox_w/redox_w.c Outdated Show resolved Hide resolved
use GPIO functions instead of manipulating pins directly
@66f94eae 66f94eae requested a review from drashna February 9, 2022 10:07
@66f94eae
Copy link
Author

@drashna @drashna @drashna

@66f94eae 66f94eae closed this Feb 15, 2022
@66f94eae 66f94eae reopened this Feb 15, 2022
@drashna drashna requested a review from a team February 21, 2022 08:17
@drashna drashna merged commit 249eb87 into qmk:master Feb 21, 2022
@drashna
Copy link
Member

drashna commented Feb 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants