Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SN74x138 demultiplexer driver #16217

Merged
merged 3 commits into from
Feb 6, 2022
Merged

Add SN74x138 demultiplexer driver #16217

merged 3 commits into from
Feb 6, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 4, 2022 •
edited
Loading

Description

The 74HC138 is a 3-to-8 line decoder/demultiplexer. The Wasdat uses this IC to drive a section of the matrix columns. Tested and working, I'm typing on it right now.

https://assets.nexperia.com/documents/data-sheet/74HC_HCT138.pdf

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 4, 2022 22:59
@fauxpark fauxpark requested a review from a team February 4, 2022 23:17
@fauxpark fauxpark changed the title Add SN74x237 demultiplexer driver Add SN74x138 demultiplexer driver Feb 6, 2022
drashna
drashna approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__((weak)) ✅

@drashna drashna merged commit e036c19 into qmk:develop Feb 6, 2022
@fauxpark fauxpark deleted the demux-74x237 branch February 6, 2022 23:13
This was referenced Feb 7, 2022
Merged
Merged
@somepin somepin mentioned this pull request Mar 15, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement feature keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr