Add matrix.c to sources for Keychron Q2 #16200
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change simply re-adds
matrix.c
toSRC
in the Keychron Q2's rules.mk file for all keyboard revisions. It was removed in #15946, although I don't fully understand why. The PR comment says:However without this file included the arrow keys no longer work (as reported in #16097). It would be ideal if @lalalademaxiya1 could confirm this file shouldn't have been removed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist